On Thu, Apr 27, 2017 at 16:56:13 +0200, Jiri Denemark wrote:
On Wed, Apr 26, 2017 at 19:52:35 +0200, Peter Krempa wrote:
Make the schema more strict for HTTP disks requiring a name and mandating exactly one source host.
ftp/tftp entries were not moved here, since http transport also will support cookies and other options, which will be added later. --- docs/schemas/domaincommon.rng | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 05efea7f2..e3dc34e08 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1556,6 +1556,19 @@ </element> </define>
+ <define name="diskSourceNetworkProtocolHTTP"> + <element name="source"> + <attribute name="protocol"> + <choice> + <value>http</value> + <value>https</value> + </choice> + </attribute> + <attribute name="name"/>
The @name attribute was originally optional. Was it optional because some protocols don't need it by http(s) needs the name? Or should it be optional even for http(s)?
@name is optional only for NBD