[PATCH v2 01/21] build-sys: drop -Winline when optimization=g
From: Marc-André Lureau <marcandre.lureau(a)redhat.com>
The warning is triggered when compiling with various build options, such
as -Doptimization=g.
From gcc(1) man page about -Winline:
seemingly insignificant changes in the source program can cause the warnings produced by
-Winline to appear or disappear.
Such flaky behaviour is best left to the user discretion.
Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com>
---
meson.build | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index c7e5947d10..5bfd37e44d 100644
--- a/meson.build
+++ b/meson.build
@@ -340,7 +340,6 @@ cc_flags += [
'-Wimplicit-int',
'-Wincompatible-pointer-types',
'-Winit-self',
- '-Winline',
'-Wint-conversion',
'-Wint-in-bool-context',
'-Wint-to-pointer-cast',
@@ -444,6 +443,12 @@ cc_flags += [
'-Wwrite-strings',
]
+if get_option('optimization') != 'g'
+ # Seemingly insignificant changes in the source program can cause the warnings
+ # produced by -Winline to appear or disappear.
+ cc_flags += [ '-Winline' ]
+endif
+
if cc.get_id() == 'clang'
# Stop CLang from doing inter-procedural analysis of calls
# between functions in the same compilation unit. Such an
--
2.47.0