Re: [libvirt] [PATCH] fix some XPath relative node resets

On 09/28/2009 06:39 PM, Laine Stump wrote: > On 09/28/2009 11:30 AM, Daniel Veillard wrote: >> The virXPath... function take extra care to preserve the XPath context >> node (ctxt->node) but in the case of virXPathString and virXPathBoolean >> they forgot to do this on the error path. This patch fixes this and >> move all ctxt->node = relnode instuctions just after the xmlXPathEval() >> to make sure this doesn't happen if this code is modified. > > ACK to this. The failure I encountered was due to a similar problem > somewhere else (patch upcoming), but these are definitely correcting a > problem. I take that back - one of my two problems *was* fixed by this patch ;-)