On 10/22/2012 07:33 AM, Daniel Veillard wrote:
On Sat, Oct 20, 2012 at 03:47:10PM -0600, Eric Blake wrote:
Yet another instance of where using plain open() mishandles files that live on root-squash NFS, and where improving the API can improve the chance of a successful probe.
* src/util/storage_file.h (virStorageFileProbeFormat): Alter signature. * src/util/storage_file.c (virStorageFileProbeFormat): Use better method for opening file. * src/qemu/qemu_driver.c (qemuDomainGetBlockInfo): Update caller. * src/storage/storage_backend_fs.c (virStorageBackendProbeTarget): Likewise. ---
v8: new patch
I don't see how passing more context informations could be a bad idea and usually we can't predict when something may break various NFS scenario except by testing the code, ACK,
Thanks; pushed. I'll still wait on the rest of the series until both of the following have happened: positive review, and qemu.git having an actual commit for drive-mirror. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org