Re: [PATCH v3 07/30] docstring: enums: admin: Add 'Since version' metadata

On Thu, Apr 21, 2022 at 15:05:06 +0200, Peter Krempa wrote: > On Wed, Apr 20, 2022 at 21:07:56 +0200, Victor Toso wrote: > > Either create or append to existing docstring, the version (git tag) > > that a given enum value was introduced in the format: > > > > Since: v1.2.3 > > > > Signed-off-by: Victor Toso <victortoso(a)redhat.com&gt; > > --- > > include/libvirt/libvirt-admin.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h > > index e414f776e4..f65886f20d 100644 > > --- a/include/libvirt/libvirt-admin.h > > +++ b/include/libvirt/libvirt-admin.h > > This looks good on the first look, although there's a possibility that > for some reason these might not be usable e.g. by preventing inclusion > of the header. Unfortunately I don't remember the history and don't feel > like digging in such old code. Okay, I dug through the history and we deliberately removed the header from the installation until the v2.0.0 release. So all virAdm* symbols must have v2.0.0 as the minimum version as none of them was usable ableit from internall use before that.