On Thu, Apr 28, 2016 at 05:02:20PM +0300, Maxim Nestratov wrote:
27.04.2016 15:31, Daniel P. Berrange пишет:
On Fri, Apr 08, 2016 at 11:47:29PM +0300, Maxim Nestratov wrote:
-------------------------------------------------------------------------------- int virBackupRestore(const char * xmlDesc, unsigned int flags) For the "managed backups" case it feels like this should be accepting a virDomainBackupPtr rather than an xmlDesc string.
Not sure because I would like to have an ability to restore not every disk a backup has but sometimes selected only.
How about doing virDomainBackupRestore(virDomainBackupPtr backip, const char *xmlDesc, unsigned int flags); Alow xmlDesc to be NULL by default, so it uses the built-in recorded XML unless you choose to override it with custom XML. This is similar to how we let people override XML during migration. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|