On Mon, 2019-07-29 at 13:17 +0100, Daniel P. Berrangé wrote:
On Fri, Jul 26, 2019 at 08:01:52PM +0200, Andrea Bolognani wrote:
Again IIUC there's nothing really stopping us from generating virtqemud*.service from libvirtd*.service.in, or at least from a common virtd*.service.in, since eg. virtqemud.service.in and virtlxcd.service.in are basically identical - it's just that you haven't unified the generation rules yet.
I'm was not anticipating sharing the service.in file, as many of the parameters will be driver specific.
It doesn't look to me like there's much more that's driver-specific in the .service files than there is in the .socket files, and we're generating the latter from a single template. But it doesn't really matter anyway, as I said if there's room for reducing duplication we can just do that after the fact :) -- Andrea Bolognani / Red Hat / Virtualization