On Tue, Mar 30, 2021 at 11:49:51 +0000, Waleed Musa wrote: Your reply email looks very broken, but I think I can find the relevant parts:
________________________________ From: Peter Krempa <pkrempa@redhat.com> Sent: Tuesday, March 30, 2021 01:42 PM To: Waleed Musa <waleedm@nvidia.com> Cc: libvir-list@redhat.com <libvir-list@redhat.com>; Moshe Levi <moshele@nvidia.com>; Adrian Chiris <adrianc@nvidia.com> Subject: Re: [Libvirt] Attach qemu commands to an running xml domain
External email: Use caution opening links or attachments
On Tue, Mar 30, 2021 at 09:35:48 +0000, Waleed Musa wrote:
[...]
2. Is there a way or API to attach qemu commands to running domain as you are doing in attaching the device using attachDeviceFlags?
No. For VMs which use <qemu:commandline> we don't formally provide support. I suggest that if you have a good use case for the attributes below, you send patches adding the functionality to libvirt if you want to have it on device hotplug.
We can't implement hot-plug
Can you elaborate why? If the options are justifiably useful and qemu upstream supports them there's nothing preventing that.