Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"
On Fri, Jun 24, 2016 at 04:53:31PM -0400, John Ferlan wrote:
Add a new secret type known as "passphrase" - it will
handle adding the
secret objects that need a passphrase without a specific username.
The format is:
<secret ...>
<uuid>...</uuid>
...
<usage type='passphrase'>
<name>mumblyfratz</name>
</usage>
</secret>
I'm not seeing the purpose of adding this secret usage type. It also
seems quite different from the usage types we have already.
The essential purpose of the usage 'name' is to allow you to figure
out what corresponding libvirt object is using the secret. So for
example with usage type=volume, the name refers to the disk path
of the volume. With usage type=iscsi or type=ceph, the name refers
to the server name.
This usage type=passphrase is not directly associating the secret
with anything, and doesn't appear to have any defined sematics for
what the 'name' should contain or refer to.
This all feels quite odd & possibly wrong to me.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|