On Tue, Feb 21, 2023 at 17:23:00 +0100, Pavel Hrdina wrote:
When user creates external snapshot with making only memory snapshot without any disks deleting that snapshot failed without reporting any meaningful error.
The issue is that the qemuSnapshotDeleteExternalPrepare function returns NULL because the returned list is empty. This will not change so to make it clear if the function fails or not return int instead and have another parameter where we can pass the list.
With the fixed memory snapshot deletion it will now correctly delete memory only snapshot as well.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2170826
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_snapshot.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-)
Reviewed-by: Peter Krempa <pkrempa@redhat.com>