Hi, Rich Thank you for your patch. The document discribes more detail than I expected :-). Thanks Atsushi SAKAI "Richard W.M. Jones" <rjones@redhat.com> wrote:
On Wed, May 28, 2008 at 02:18:50PM +0100, Daniel P. Berrange wrote:
On Wed, May 28, 2008 at 11:21:05AM +0900, Atsushi SAKAI wrote:
Hi, Rich and Dan
Thank you for fixing this. I think it should be noted about submitting patch on HACKING file or others. How do you think? (like make check; make syntax-check; make tests)
Yes, basically the three things you should run before committing patches are
make check make syntax-check make valgrind (in the tests/ sub-dir)
The latter checks for memory leaks.
Of course I myself forget this often - which is why we have the automated nightly builds, so we never miss the problem for longer than a day
Suggested patch to HACKING file.
Rich.
-- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top