On 1/27/25 15:34, Michal Prívozník wrote:
On 1/27/25 13:42, Boris Fiuczynski wrote:
> On 1/24/25 13:21, Michal Privoznik wrote:
>> This is an example test for virtio-mem on s390. Currently, both
>> virtio-mem devices are placed onto PCI bus, but this will soon
>> change and the test will be updated.
>>
>> Signed-off-by: Michal Privoznik<mprivozn(a)redhat.com>
>> ---
>> ...hotplug-virtio-mem-s390x.s390x-latest.args | 41 +++++++++++
>> ...-hotplug-virtio-mem-s390x.s390x-latest.xml | 71 +++++++++++++++++++
>> .../memory-hotplug-virtio-mem-s390x.xml | 59 +++++++++++++++
>> tests/qemuxmlconftest.c | 1 +
>> 4 files changed, 172 insertions(+)
>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-
>> s390x.s390x-latest.args
>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-
>> s390x.s390x-latest.xml
>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-
>> s390x.xml
>
> I guess with David's response to patch 7 this should not be possible but
> currently is because of recorded tests/qemucapabilitiesdata/
> caps_10.0.0_s390x.replies file of qemu v9.2.0-1203-gd6430c17d7.
>
Yeah, trying to start such domain results in QEMU throwing an error:
qemu-system-s390x: -device virtio-mem-pci: PCI-attached virtio based
memory devices not supported
But the point of this patch is to make it more obvious how
virtio-mem-ccw is configured (patch 7/8).
Michal
Looks like the virtio-mem-pci device test should remain and another test
virtio-mem-ccw should be added in patch 7. I suggest to adjust the test
name(s).
With that
Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com>
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294