On 03/30/14 05:37, Eric Blake wrote:
Some preparatory work before consolidating storage volume
structs with the rest of virstoragefile. Making these
changes allows a volume target to be much closer to the
virStorageSource struct.
While I don't think that the refactor of the target is a good idea ...
* src/conf/storage_conf.h (_virStorageVolTarget): Change perms to
pointer, enhance comments.
* src/conf/storage_conf.c (virStorageVolDefFree)
(virStorageVolDefParseXML, virStorageVolTargetDefFormat): Update
clients.
* src/storage/storage_backend_fs.c (createFileDir): Likewise.
* src/storage/storage_backend.c (virStorageBackendCreateBlockFrom)
(virStorageBackendCreateRaw, virStorageBackendCreateExecCommand)
(virStorageBackendUpdateVolTargetInfoFD): Likewise.
* src/storage/storage_backend_logical.c
(virStorageBackendLogicalCreateVol): Likewise.
* src/storage/storage_backend_disk.c
(virStorageBackendDiskMakeDataVol)
(virStorageBackendDiskPartTypeToCreate): Likewise.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/conf/storage_conf.c | 26 ++++++++++++------
src/conf/storage_conf.h | 7 ++---
src/storage/storage_backend.c | 50 ++++++++++++++++++++---------------
src/storage/storage_backend_disk.c | 14 +++++-----
src/storage/storage_backend_fs.c | 6 ++---
src/storage/storage_backend_logical.c | 6 ++---
6 files changed, 63 insertions(+), 46 deletions(-)
... ACK to this patch
Peter