-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/03/2013 07:28 AM, Daniel P. Berrange wrote:
On Tue, Apr 02, 2013 at 06:11:23PM -0400, Dan Walsh wrote:
Python makes assumptions about __METHOD names that will break some of the other patches that I am adding, involving inheritance of classes. The _METHODS are treated the same as any methods, but still give maintainers an idea that they should not be used.
None of this code is public API, so I'm not sure there's any point in even using '_' - everything is internal. So I'd just remove all use of leading '_' in method names.
Daniel
I was using them more as an indicator to myself and future maintainers which interfaces to use publicly. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlFcOHYACgkQrlYvE4MpobMdtACggGLOeNQ330fcqzq0tXIAxxin KdEAoLZqMFkYoW4fuAZo8KKJYkB2xyvP =YHFN -----END PGP SIGNATURE-----