On Fri, May 09, 2008 at 10:42:08PM +0100, Daniel P. Berrange wrote:
On Fri, May 09, 2008 at 11:40:39PM +0200, Jim Meyering wrote:
"Daniel P. Berrange" <berrange@redhat.com> wrote:
This patch removes all use of strcmp, strncmp, strcasecmp and strncasecmp in favour of the equality macros we have defined in internal.h, eg STREQ, STRNEQ, STRNEQLEN, STREQLEN, etc, etc
Nice. With that, you can remove sc_prohibit_strcmp from the list of disabled checks in Makefile.cfg. You might want to extend the corresponding regexp in Makefile.maint to prohibit the other completely excluded functions like strncmp.
BTW, did you make this change automatically? or do a binary before/after comparison. In which case there's not much point in reviewing the details...
No I did it manually & checked with inspection. Could try a binary diff with & without the patch if you want...
Actually a binary diff won't work because of places where I changed from strncmp to STRPREFIX - the latter includes a calls to strlen instead of hardcoding the constant Dan -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|