On Fri, 2019-07-05 at 18:25 +0100, Daniel P. Berrangé wrote:
On Thu, Jul 04, 2019 at 08:22:04AM +0200, Michal Prívozník wrote:
Interestingly, I'm unable to reproduce on my virtual FreeBSD. From the CI logs it looks like the test did not pick up XATTR functions from qemusecuritymock but the real ones from util/virfile.c. But then again, something fishy must be going on since I cannot reproduce this on my FreeBSD machine.
I could reproduce it .... once I actually installed the prereqs to make QEMU get enabled in configure
I guess you guys didn't use lcitool to prepare the FreeBSD guest in question? Or is there some problem with it?
for some reason we have a dep on readline in the m4/virt-yajl.m4 file that looks liek its probobly a bug.
Yeah, I told Jano to look at m4/virt-readline.m4 for inspiration but perhaps he took it a bit too far ;) And then of course I failed to notice during review :( I just posted a patch fixing this oversight: https://www.redhat.com/archives/libvir-list/2019-July/msg00280.html -- Andrea Bolognani / Red Hat / Virtualization