Re: [libvirt] [PATCH 1/7] tests: Add qemuxml2xml tests for <seclabel> handling

On 01/12/2011 10:22 AM, Cole Robinson wrote: At first, I though this should be listing _both_ qemuxml2xml{out,}data, rather than just one or the other, but now I see that you've moved the only five files that were in that directory so that all qemu*.xml files are in a single location, and adjusted the test to match. Nice cleanup, but incomplete - you also need to tweak tests/Makefile.am to drop reference to the deleted qemuxml2xmloutdata directory, so that 'make dist' won't complain. This would have been a little more obvious to me if you had used git diff rename compression (git config diff.renames true), rather than showing the moved files as deletions and creations. In fact, separating into two patches (file movement consolidation, vs. new tests), might be nice, if you're up to the task, but I won't insist. Hmm, this silently ignores overflow if run in a deeply nested hierarchy. Someday, we should switch these to virAsprintf (and as a bonus, it avoids PATH_MAX stack allocation). But that's independent of this patch. Conditional ACK, once you fix the tests/Makefile.am EXTRA_DIST nit. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org