Re: [libvirt] [PATCH 2/4] libxl: fix empty string check for channel path

The libxl code was checking that a 'char *' was != '\0', instead of checking the first element in the string Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 57ec661..ea28c93 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -1121,7 +1121,7 @@ libxlDomainCreateChannelPTY(virDomainDefPtr def, libxl_ctx *ctx) &channelinfo); if (!ret && channelinfo.u.pty.path && - channelinfo.u.pty.path != '\0') { + *channelinfo.u.pty.path != '\0') { VIR_FREE(chr->source->data.file.path); ignore_value(VIR_STRDUP(chr->source->data.file.path, channelinfo.u.pty.path));