Re: [libvirt] [PATCH v4 3/9] util: Management routines for scsi_host devices
[...]
+
+/* For virReportOOMError() and virReportSystemError() */
+#define VIR_FROM_THIS VIR_FROM_NONE
+
Made a minor adjustment to move this above the VIR_LOG_INIT - it's just
cosmetic...
[...]
+virSCSIVHostDevicePtr
+virSCSIVHostDeviceNew(const char *name)
+{
+ virSCSIVHostDevicePtr dev;
+
+ if (VIR_ALLOC(dev) < 0)
+ return NULL;
+
+ if (VIR_STRDUP(dev->name, name) < 0) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("dev->name buffer overflow: %s"),
+ name);
+ goto error;
+ }
+
+ if (virAsprintf(&dev->path, "%s/%s",
+ SYSFS_VHOST_SCSI_DEVICES, name) < 0)
+ goto cleanup;
I believe this is goto error; (I can change before push)
ACK
John