23 Jan
2013
23 Jan
'13
6:12 p.m.
On 01/23/2013 11:02 AM, Richard W.M. Jones wrote:
On Wed, Jan 23, 2013 at 05:06:35PM +0000, Daniel P. Berrange wrote:
+ memset(nodeinfo, 0, sizeof(nodeinfo)); +
Of course i meant sizeof(*nodeinfo)
Yikes. Doesn't libvirt have some type of VIR_* macro to either catch that error systematically or to allocate pre-cleared memory?
VIR_MALLOC guarantees pre-cleared memory, but in this case, nodeinfo was passed in by the caller rather than something that we control directly. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org