Re: [PATCH v2 18/27] util: new functions virFirewallParseXML() and virFirewallFormat()

23 Apr 2024


      On 4/23/24 6:59 AM, Daniel P. Berrangé wrote:
...
On Sun, Apr 21, 2024 at 10:53:26PM -0400, Laine Stump wrote:
...
+ */
+int
+virFirewallParseXML(virFirewall **firewall,
+                    xmlNodePtr node,
+                    xmlXPathContextPtr ctxt)
+{
  [...]
+            nargs = virXPathNodeSet("./item", ctxt, &argsNodes);
+            if (nargs < 0)
+                return -1;
+            if (nargs == 0)
+                continue;
In an earlier patch you indicated that nargs == 0 was an error
condition we should check and report. How about reporting it
here too, rather than delaying it ?
Makes sense.