On 04/19/2011 12:23 AM, Matthias Bolte wrote:
2011/4/19 Eric Blake <eblake@redhat.com>:
Gnulib already guarantees <stdbool.h>, so it is easier to just use the standardized spellings.
* tools/virsh.c (vshCmdDef): Change callback to return real bool. (__vshControl): Change several fields to bool. (vshCommandOptBool): Change return type. All callers updated. * tools/Makefile.am (virsh-net-edit.c, virsh-pool-edit.c): Likewise. ---
Mostly mechanical.
tools/Makefile.am | 4 +- tools/virsh.c | 1674 ++++++++++++++++++++++++++--------------------------- 2 files changed, 835 insertions(+), 843 deletions(-)
Looks good in general, but you missed some places for s/int/bool/. Instead of pointing them out in the diff, here's a patch to be merged into yours.
ACK with the attached patch merged in.
ACK to your additions, so I've pushed the combined patch. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org