On 01/11/2012 06:13 AM, Osier Yang wrote:
Disk "type" and "device" are generally interesting stuffs the user who wants to known too. Though it's likely breaks the script which parses the command output by field (e.g. awk), putting them in the head is better, as it coheres with the user's habit more. (Trying to find the small word (type, device) after a very long file path (could be) sounds not a good idea). --- tools/virsh.c | 14 +++++++++++--- tools/virsh.pod | 14 +++++++------- 2 files changed, 18 insertions(+), 10 deletions(-)
Since this risks breaking existing scripts that were depending on the old column ordering, I'd prefer that you resubmit this as a v2 patch, and add a new option (perhaps domblklist --full), and only output the new columns when the new option is in use. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org