30 Jan
2012
30 Jan
'12
5:41 p.m.
On 01/25/2012 10:02 PM, Eric Blake wrote:
On 01/25/2012 09:58 AM, Laine Stump wrote:
Since these two items are now in the virDomainDeviceInfo struct, it makes sense to parse/format them in the functions written to parse/format that structure. Not all types of devices allow them, so two internal flags are added to indicate when it is appropriate to do so.
I was lucky - only one test case needed to be re-ordered! --- src/conf/domain_conf.c | 224 +++++++++++--------- tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml | 2 +- 2 files changed, 123 insertions(+), 103 deletions(-) ACK. Nice use of internal flags to share logic while still keeping the overall parsing and output the same.
Thanks. I pushed this now.