Re: [libvirt] [PATCH v3] nwfilter:
On 08/13/2010 03:11 PM, Stefan Berger wrote:
>> + virNWFilterPoolLoadAllConfigs(conn,
>> + &driverState->pools,
>
> Indentation problem still looks like it is here.
The indentation problem doesn't exist in my local patch. Could this be
another Thunderbird formatting issue?
Sorry, not this time. The fact that there are two leading + means that
'git diff' really did see two lines, and your second line is flush left
instead of indented (and even still in the copy where you resent with a
better subject line).
>
>> @@ -1912,7 +1926,11 @@ qemudStartup(int privileged) {
>> 1, NULL, NULL) < 0)
>> goto error;
>>
>> - qemuReconnectDomains(qemu_driver);
>> + conn = virConnectOpen(qemu_driver->privileged ?
>> + "qemu:///system" :
>> + "qemu:///session");
>
> How come this one is conditional, but the other one was hard-coded to
> system?
The same type of check exists several times in this file of the qemu
driver. I ended up hard-coding it in the nwfilter driver case above since
I don't have a flag in the nwfilter driver for whether it's privileged or
not and I don't know what the difference would be.
The difference is whether you communicate with the libvirtd process
running as root, or with just the session-specific qemu command. If you
are running unprivileged but attempt to connect to qemu:///system, this
will cause an authentication attempt (you have to supply the root
password); but if the user is only running a qemu:///session, this is
not what they want.
I'm not sure what makes the right thing to do here; hopefully danpb can
shed some better insight into this.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)