On 02/17/2016 03:24 AM, Ian Campbell wrote:
On Tue, 2016-02-16 at 14:45 -0700, Jim Fehlig wrote:
xl/libxl already supports qemu's network-based block backends such as nbd and rbd. libvirt has supported configuring network disks for long time too. This series marries the two in the libxl driver and in the xl<->xml converter. Only rbd supported is added in this series. Support for other backends such as nbd and iscsi can be added as a follow-up improvement. This all looks sensible to me, FWIW.
Thanks for taking a look!
One question, in patch 3's commit log should the example be double escaping the \\ or not? Based on your updates to $xen/docs/misc/xl-disk- configuration.txt (posted separately on xen-devel) I had expected they would.
Yes, you are correct. The test and conversion code in patch 3 is wrong in that regard too. I've fixed it in V2. Regards, Jim