Re: [libvirt] [PATCH] docs: add SVGs for sticker logos
On Mon, Feb 26, 2018 at 03:51:32PM +0000, Daniel P. Berrangé wrote:
On Mon, Feb 26, 2018 at 04:35:54PM +0100, Erik Skultety wrote:
> On Mon, Feb 26, 2018 at 11:00:06AM +0000, Daniel P. Berrangé wrote:
>
> Since you edited the template you referenced ^above, you added the whole thing
> which I'm not sure is really necessary. There's also some leftover star
object.
Yeah, I was not 100% sure whether it was a good idea to trim all the extra
layers off or not, but as you say, it does make a big template file. So
minimising it makes sense.
Having the outer border, bleed, artwork, logo and trim lines should IMHO
suffice.
> I think that we can keep the SVG as small as possible (that's actually the
> reason why I created mine from scratch) an only incorporate what we absolutely
> need, like the shape itself and measurements, so that we can export it to PDF
> (I've heard that printing services actually prefer PDF). Also, I noticed that
> you "went by eye" with placing the logo, I've got patches to mitigate
this, so
> we should be then able to use proper alignment.
Yeah, I did it by eye :-) Did you think it needs tweaking more ?
Nah, not really, any misalignment is hard to spot, I just like the algorithmic
way of aligning objects, in fact I spent quite a bit of Saturday night to give
up on aligning it by hand (I was again creating a mesh of hexagons to send as a
"poll request"), with the URL as you wanted to see - spoiler alert -
doesn't
look good) and started analyzing the logo itself, what the culprit was :/, I was
probably just over-engineering things as usual instead of fast prototyping.
> The spec doesn't specify the thickness of the border, I measure 4.17 here, I
> received another template which also a few projects follow with the border
> sized at 3.26 (not that I would care that much), the bleed area is the same
> 1.5mm in both cases.
Yeah, I just followed the border size that the template showed, but it does
feel perhaps too heavy, even hiding the bleed. We could thin it out some
more perhaps.
Try to bring it down by 1mm it'll look much more balanced. If you include the 2
adjustments (keep the overall size down and make the border thinner):
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>