Re: [libvirt PATCH] ci: Use fedora image for code style checking
On Mon, 2020-06-22 at 11:30 +0100, Daniel P. Berrangé wrote:
On Mon, Jun 22, 2020 at 12:01:42PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-06-22 at 10:00 +0100, Daniel P. Berrangé wrote:
> > For other apps we've tended towards Ubuntu 20.04 when CentOS wasn't
> > viable, as that'll be around a reasonably long time.
>
> Yeah, but Ubuntu doesn't have cppi either :)
Oh well, openSUSE it is then, but I do wonder if it is really worth
having this cppi check when so many platforms are missing it.
Fedora, Gentoo and openSUSE all have it, and since those seem to be
the operating systems used by the majority of libvirt contributors I
would say the chances of issues being spotted early is reasonably
high; once we have a variation of this commit in, we'll start
catching it in CI as well, so that doesn't sound too bad to me.
Jonathon, can you go ahead and post a v2 that uses openSUSE instead
of Fedora please? :)
--
Andrea Bolognani / Red Hat / Virtualization