Re: [libvirt] [PATCH] qemu: bulk stats: add pcpu placement information
----- Original Message -----
From: "Eric Blake" <eblake(a)redhat.com>
To: "Francesco Romani" <fromani(a)redhat.com>, libvir-list(a)redhat.com
Sent: Wednesday, December 10, 2014 6:16:07 PM
Subject: Re: [libvirt] [PATCH] qemu: bulk stats: add pcpu placement information
> +++ b/src/libvirt-domain.c
> @@ -10888,6 +10888,8 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
> * from virVcpuState enum.
> * "vcpu.<num>.time" - virtual cpu time spent by virtual CPU
<num>
> * as unsigned long long.
> + * "vcpu.<num>.physical" - real CPU number on which virtual CPU
<num> is
> + * running, or -1 if offline.
As which type?
> + if (virTypedParamsAddULLong(&record->params,
> + &record->nparams,
> + maxparams,
> + param_name,
> + cpuinfo[i].cpu) < 0)
ULLong cannot hold -1. Is 'int' sufficient, since physical CPU numbers
will never exceed 32 signed bits? (A machine with 2 billion cores seems
unlikely...)
Oops, hit 'send' too early, apologies for the noise.
Fixed patch coming in a snap.
Thanks and bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani