On 02/05/2016 02:17 PM, Laine Stump wrote:
On 02/05/2016 02:04 PM, Laine Stump wrote:
On 01/28/2016 03:30 PM, Cole Robinson wrote:
Most of the qemuargv2xml tests are parsing old style qemu command lines (with -disk, -serial, etc), and it gets its input from qemuxml2argv output.
But since we've raise the minimum supported qemu version to 0.12.0, which supports -device, once that changes propagates through libvirt the vast majority of qemuxml2argv output is _not_ going to be using old style qemu options.
In preparation for this, switch qemuargv2xml to use its own copies of input and output, so it's not tied to qemuxml2argv results.
This is just a straight copy of the current tests.
I'm actually surprised to see this wasn't already the case! As many holes as the qemu commandline parser has, I would have figured there would be a total of 0 test cases that would survive a round trip xml->qemu->xml intact!
This does bring up an important point that, although we can raise the qemu commandline *generator* to always assume QEMU_CAPS_DEVICE, we can't do that for the qemu commandline *parser* (which will forever have to support all those old options :-(
ACK.
BTW, I didn't mention it before, but I think these files also should lose (or rather "never gain" :-) the "qemuargv2xml-" prefix - it's already there in the directory name, no need to unnecessarily lengthen the filename.
I agree with this bit. Once these patches go in I'll start a discussion about it, I'd rather do it for every file in one go if that's what we decide. Pushed this patch now, thanks! - Cole