On Thu, 6 Mar 2025 13:51:35 +0100 Anthony Harivel <aharivel@redhat.com> wrote:
Hi,
The enhancement in this new version based on last feedback are:
* add more documentation on limitation of the feature * no more double check of the vmsr socket, once is enough * virQEMUBuildBufferEscapeComma() is used for user input Path
Because there is no garantie at the moment that the helper will be one day managed by libvirt, I decided not adding any preparation about this to avoid any confusion but add more documentation.
If the helper is managed in libvirt, the patch introducing it will also add the necessary API like mention on the previous review (i.e mode='unmanaged').
I'd prefer wait till QEMU side is refactored to a more maintainable design (which would include CLI changes). So that libvirt won't have to maintain both current (which should be deprecated/removed) and to be CLI interface.
Thanks Anthony
Anthony Harivel (1): qemu: Add support for RAPL MSRs feature
docs/formatdomain.rst | 15 +++++++++++++++ src/conf/domain_conf.c | 18 ++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10 ++++++++++ src/qemu/qemu_command.c | 9 +++++++++ tests/qemuxmlconfdata/kvm-features-off.xml | 1 + .../kvm-features.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/kvm-features.xml | 1 + 8 files changed, 57 insertions(+), 1 deletion(-)