Re: [libvirt] PATCH add q35 support ide
On Thu, Nov 30, 2017 at 09:50:01AM +0800, Paul Schlacter wrote:
hello everyone:
In q35 motherboard use ide, Currently, the qemu has supported q35
Motherboard support ide bus
IIRC, this is not quite correct - q35 has a built-in SATA controller,
as opposed to IDE controller. You can potentially add an IDE controller
as an optional extra.
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index cc7596b..2dbade8 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -7188,6 +7188,7 @@ bool
qemuDomainMachineHasBuiltinIDE(const char *machine)
{
return qemuDomainMachineIsI440FX(machine) ||
+ qemuDomainMachineIsQ35(machine) ||
STREQ(machine, "malta") ||
STREQ(machine, "sun4u") ||
STREQ(machine, "g3beige");
I don't see an equivalent qemuDomainMachineHasBuiltinSATA method,
so I wonder if there's any logic we're missing in this respect ?
Perhaps Laine or someone more recenty familiar wit the code can
comment...
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|