Re: [libvirt] [PATCH] rbd: Set r variable so it can be returned should an error occur

On Fri, Jan 15, 2016 at 01:52:16PM +0100, Wido den Hollander wrote:

This was reported in bug #1298024 where r would be filled with the return code of rbd_open().

Should rbd_snap_unprotect() fail for any reason the virReportSystemError call would return 'Success' since rbd_open() succeeded.

https://bugzilla.redhat.com/show_bug.cgi?id=1298024 Signed-off-by: Wido den Hollander <wido@widodh.nl> --- src/storage/storage_backend_rbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

ACK and pushed Jan