Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

Il 11/03/2013 04:23, Osier Yang ha scritto: > On 2013年02月26日 01:44, Paolo Bonzini wrote: >> QEMU added -drive in 2007, and NBD in 2008. Both appeared first in >> release 0.10.0. Thus the code to support network disks without -drive >> is dead, and in fact it incorrectly escapes commas. Drop it. > > The network disks support appeared in 0.8.7: Jan 4 2011 actually. > > commit 036ad5052b43fe9f0d197e89fd16715950408e1d > Author: MORITA Kazutaka&lt;morita.kazutaka(a)lab.ntt.co.jp&gt; > Date: Mon Dec 6 16:24:09 2010 +0900 > > add network disk support > > This patch adds network disk support to libvirt/QEMU. The currently > supported protocols are nbd, rbd, and sheepdog. The XML syntax is like > this: > > <disk type="network" device="disk"> > <driver name="qemu" type="raw" /> > <source protocol='rbd|sheepdog|nbd' name="...some image > identifier..."> > <host name="mon1.example.org" port="6000"> > <host name="mon2.example.org" port="6000"> > <host name="mon3.example.org" port="6000"> > </source> > <target dev="vda" bus="virtio" /> > </disk> > > Signed-off-by: MORITA Kazutaka&lt;morita.kazutaka(a)lab.ntt.co.jp&gt; > > I believe -drive support is before 0.8.7, but how about libvirt is new > enough with the network disk support, and qemu too old without -drive > support? Sorry for the confusion---I meant both -drive and NBD were in QEMU 0.10.0. There is no released QEMU version that has only one of -drive and NBD, and not even a source control commit that has NBD but not -drive.