Re: [libvirt] [PATCH 2/3] rbd: Change from static to alloc contexts

Rather than use static/stack state context pointers, let's allocate and

free the state context pointer. In doing so, we'll shrink the code a bit since many routines perform the same initialization sequence.

Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; --- src/storage/storage_backend_rbd.c | 136 +++++++++++++++++++------------------- 1 file changed, 69 insertions(+), 67 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 4e82232..37375c0 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -224,6 +224,42 @@ virStorageBackendRBDCloseRADOSConn(virStorageBackendRBDStatePtr ptr) time(0) - ptr->starttime); } + +static void +virStorageBackendRBDFreeStateContext(virStorageBackendRBDStatePtr *ptr)

+{ + if (!*ptr) + return; + + virStorageBackendRBDCloseRADOSConn(*ptr); + + VIR_FREE(*ptr); +} + + +static virStorageBackendRBDStatePtr +virStorageBackendRBDAllocStateContext(virConnectPtr conn, + virStoragePoolObjPtr pool)

+{ + virStorageBackendRBDStatePtr ptr; + + if (VIR_ALLOC(ptr) < 0) + return NULL;