Re: [libvirt] "shadows a global declaration" warnings in virsh
On 03/12/2010, at 9:04 PM, Jiri Denemark wrote:
>>> virsh.c: In function 'cmdRunConsole':
>>> virsh.c:735: warning: declaration of 'devname' shadows a global
declaration [-Wshadow]
>>> /usr/include/stdlib.h:290: warning: shadowed declaration is here [-Wshadow]
>>> virsh.c: In function 'cmdConsole':
>>> virsh.c:765: warning: declaration of 'devname' shadows a global
declaration [-Wshadow]
>>> /usr/include/stdlib.h:290: warning: shadowed declaration is here [-Wshadow]
>>> virsh.c: In function 'vshReadlineInit':
>>> virsh.c:11575: warning: assignment discards qualifiers from pointer target
type
>>>
>>> Haven't looked into it yet as they're only warnings. Anyone know if
they're important enough
>>> to look into?
Well, all warnings are important since we should be able to build with
--enable-compile-warnings=error
> Sorry, should have mentioned that they're only showing up in OSX, but not in
Fedora 13. :)
Yeah, I was thinking it was the case. Apparently, OSX has devname declared in
/usr/include/stdlib.h:290. I wonder if it's only OSX or other BSD systems are
affected as well.
Looks like it from what Matthias just mentioned. Looking in /usr/include/stdlib.h on the
box here,
it shows these:
int daemon(int, int) __DARWIN_1050(daemon)
__OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0,__MAC_10_5,__IPHONE_2_0,__IPHONE_2_0);
char *devname(dev_t, mode_t);
char *devname_r(dev_t, mode_t, char *buf, int len);
char *getbsize(int *, long *);
int getloadavg(double [], int);
const char
*getprogname(void);
(included a few extra lines for context)