Nice! For series:
Tested-by: Alex Williamson <alex.williamson@redhat.com>
(with KVMGT vGPU mdev)
Thank you very much for the effort Alex. Given its current state, I'm glad KVMGT was testable with my patches :).
Nit, if I configure a VM for an invalid mdev uuid, I get the following error message:
Error starting domain: Requested operation is not valid: mediated devices are not supported by this kernel
Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/asyncjob.py", line 88, in cb_wrapper callback(asyncjob, *args, **kwargs) File "/usr/share/virt-manager/virtManager/asyncjob.py", line 124, in tmpcb callback(*args, **kwargs) File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 83, in newfn ret = fn(self, *args, **kwargs) File "/usr/share/virt-manager/virtManager/domain.py", line 1404, in startup self._backend.create() File "/usr/lib64/python2.7/site-packages/libvirt.py", line 1035, in create if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self) libvirtError: Requested operation is not valid: mediated devices are not supported by this kernel
In this case it should really just be a device not found error, the speculation that the kernel doesn't support mediated devices is incorrect. Thanks,
Noted, I'll address this as part of, presumably, v3 when I get a patch review. Thanks, Erik