On Thu, 22 Jun 2017 16:16:16 +0100 Joao Martins <joao.m.martins@oracle.com> wrote:
On 06/12/2017 07:54 PM, Wim Ten Have wrote:
From: Wim ten Have <wim.ten.have@oracle.com>
Test a bidirectional xen-xl domxml to and from native for numa support administration as brought under this patch series.
Signed-off-by: Wim ten Have <wim.ten.have@oracle.com> --- ... diff --git a/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml new file mode 100644 index 0000000..a576881 --- /dev/null +++ b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml @@ -0,0 +1,54 @@ +<domain type='xen'> + <name>XenGuest2</name> + <uuid>c7a5fdb2-cdaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>8388608</memory> + <currentMemory unit='KiB'>8388608</currentMemory> + <vcpu placement='static'>8</vcpu> + <os> + <type arch='x86_64' machine='xenfv'>hvm</type> + <loader type='rom'>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='cdrom'/> + </os> + <features> + <acpi/> + <apic/> + <pae/> + </features> + <cpu> + <topology sockets='4' cores='2' threads='1'/>
We don't set/support topology info then it shouldn't be in the xml. Therefore the test with nodistances will fail right? In that case <topology/> should be removed then.
Right ... specific <topology .../> line should not be there. It sneaked in because i was playing with code supporting topology and unfortunate forgot to delete specific line in the test. Reason i forgot is that specific line does _NOT_ cause any issue to testing as for 'fullvirt-vnuma-nodistances' the CANONs can only go one-way (domxml to native).
diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c + DO_TEST_PARSE("fullvirt-vnuma-nodistances", false);
Going backwards (domxml from native) would create XML topics listing, ignorant, default distances generated making the -nodistance CANON match fail its xml representation.
Albeit the other test doesn't have <topology/> element which is good :)
Indeed ... <topology/> was not suppost to be in. Thanks for spotting this one. I'll remove it under v2. Rgds, - Wim.