Re: [libvirt] [PATCH] conf: Don't accept dummy values for <memoryBacking/> attributes

On Tue, Feb 21, 2017 at 05:31:42PM +0100, Michal Privoznik wrote:

Our virSomeEnumTypeFromString() functions return either the value of item from the enum or -1 on error. Usually however the value 0 means 'this value is not set in the domain XML, use some sensible default'. Therefore, we don't accept corresponding string in domain XML, for instance:

<memoryBacking> <source mode="none"/> <access mode="default"/> <allocation mode="none"/> </memoryBacking>

should be rejected as invalid XML.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

ACK