Re: [libvirt] [PATCH v2 04/10] qemu: New cap flag for scsi-generic

On 04/03/2013 11:51 AM, Osier Yang wrote: > On 03/04/13 11:48, Han Cheng wrote: >> >> >> On 04/03/2013 11:41 AM, Osier Yang wrote: >>> On 01/04/13 20:00, Han Cheng wrote: >>>> diff --git a/src/qemu/qemu_capabilities.h >>>> b/src/qemu/qemu_capabilities.h >>>> index 7101f67..a3d8595 100644 >>>> --- a/src/qemu/qemu_capabilities.h >>>> +++ b/src/qemu/qemu_capabilities.h >>>> @@ -174,6 +174,8 @@ enum virQEMUCapsFlags { >>>> QEMU_CAPS_VIRTIO_CCW = 132, /* -device virtio-*-ccw */ >>>> QEMU_CAPS_DTB = 133, /* -dtb file */ >>>> QEMU_CAPS_SCSI_MEGASAS = 134, /* -device megasas */ >>>> + QEMU_CAPS_SCSI_GENERIC = 135, /* -device scsi-generic */ >>>> + QEMU_CAPS_SCSI_GENERIC_BOOTINDEX = 136, /* >>>> scsi-generic.bootindex */ >>>> QEMU_CAPS_LAST, /* this must always be the last item */ >>>> }; >>> >>> Looks good, but don't you need to update qemuhelptestdata to make >>> sure the "make check" is not broken? >> Yes, these changes were made in 10/10. > > It has to be be in this patch, every single patch should *not* break the > build. Actually, this doesn't break this as we place both changes on qemuhelptestdata and qemuhelptest.c in 10/10. Or, shall we move these from 10/10 into this?

Cheng