Re: [libvirt] [PATCH 03/14] Record hotplugged USB device in LXC live guest config

On 02/07/2014 08:33 AM, Daniel P. Berrange wrote:

After hotplugging a USB device, the LXC driver forgot to add the device def to the virDomainDefPtr.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_driver.c | 5 +++++ 1 file changed, 5 insertions(+)

ACK.

diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index cd48be8..1c7abb9 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -3943,6 +3943,9 @@ lxcDomainAttachDeviceHostdevSubsysUSBLive(virLXCDriverPtr driver,

mode = 0700 | S_IFCHR;

+ if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs+1) < 0)

Space around + -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org