Re: [PATCH 10/10] qemu-replies-tool: Dump 'device-list-properties'
On Thu, Jan 25, 2024 at 10:10:32 -0800, Andrea Bolognani wrote:
On Tue, Jan 16, 2024 at 05:12:44PM +0100, Peter Krempa wrote:
> + --dump-device-list-properties
> +
> + Dumps all properties (in stable order) of devices (in order libvirt queries
> + them) along with types and default values.
Isn't the device order stable as well? The lines are generated one
device at a time, then sorted all in one go.
Now I'm wondering whether I've messed up moving of this code (python--)
or made the change on purpose.
The order of the devices in the .replies file is stable because it's
driven by the order how libvirt queries the devices.Thus it should be
sufficient to do them in order of the replies file.
I'll adjust the docs as I don't remember why the code ended up this way
:D
Other than that,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization