On Fri, Aug 28, 2009 at 11:21:07AM +0100, Daniel P. Berrange wrote:
Latest upstream QEMU can be built with Xen support, which introduces a -xen-domid argument. This was mistakenly detected as -domid due to old Xenner support. Adapt to cope with both syntax. Also only set domid if the virt type is xen, or the guest type is xen
* src/qemu_conf.c, src/qemu_conf.h: Detect new -xen-domid flag in preference to -domid.
Patch looks fine except I had to rebase it
* tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml: Fix domain type to be xen
But the test are failing for me for example we end up with <os> <type arch='x86_64' machine='pc'>xen</type> <boot dev='hd'/> </os> and that doesn't match ostypehvm nor ostypexen, the first one because the value is not hvm the second one because the machine='pc' is not one of the accepted attributes values. Attaching the result of my rebase, but a bit of checking still needed I think, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/