Re: [libvirt] [PATCH v5 3/5] virsh: supports guest panicked

On 06/05/2013 03:54 AM, Chen Fan wrote: This should probably be squashed in with your 1/5 patch that introduces the new enum values in the first place. In fact, patch 1/5 fails to compile with decent gcc: virsh-domain-monitor.c: In function 'vshDomainStateReasonToString': virsh-domain-monitor.c:178:9: error: enumeration value 'VIR_DOMAIN_RUNNING_CRASHED' not handled in switch [-Werror=switch] virsh-domain-monitor.c:210:9: error: enumeration value 'VIR_DOMAIN_PAUSED_GUEST_PANICKED' not handled in switch [-Werror=switch] virsh-domain-monitor.c:236:9: error: enumeration value 'VIR_DOMAIN_SHUTDOWN_CRASHED' not handled in switch [-Werror=switch] virsh-domain-monitor.c:268:9: error: enumeration value 'VIR_DOMAIN_CRASHED_PANICKED' not handled in switch [-Werror=switch] virsh-domain-monitor.c: At top level: cc1: error: unrecognized command line option "-Wno-unused-command-line-argument" [-Werror] cc1: all warnings being treated as errors and ALL patches in the series should be independently compilable. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org