Re: [libvirt] [PATCH 11/11] iscsi: Add parent wwnn/wwpn or fabric capability for createVport

On Fri, Nov 18, 2016 at 09:26:37AM -0500, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1349696 > > As it turns out using only the 'parent' to achieve the goal of a > consistent vHBA parent has issues with reboots where the scsi_hostX > parent could change to scsi_hostY causing either failure to create > the vHBA or usage of the wrong HBA for our vHBA. > > Thus add the ability to search for the "parent" by the parent wwnn/ > wwpn values or just a fabric_name if someone only cares to ensure > usage of the same SAN for the vHBA. > > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > src/storage/storage_backend_scsi.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > @@ -732,14 +750,15 @@ createVport(virConnectPtr conn, > "cannot find one on this host")); > goto cleanup; > } > + skip_capable_check = true; > } > > if (virGetSCSIHostNumber(parent_hoststr, &parent_host) < 0) > goto cleanup; > > - if (adapter->data.fchost.parent && !virIsCapableFCHost(NULL, > parent_host)) { > + if (!skip_capable_check && !virIsCapableFCHost(NULL, parent_host)) { > virReportError(VIR_ERR_XML_ERROR, > - _("parent '%s' specified for vHBA is not vport > capable"), > + _("parent '%s' is not vport capable"), Why the error message change?

ACK to the rest. Jan