On 6/29/23 3:02 PM, Peter Krempa wrote:
diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live-with-ccw-virtio.xml b/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live-with-ccw-virtio.xml index 82402ffe1b..42f89a07a2 100644 --- a/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live-with-ccw-virtio.xml +++ b/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live-with-ccw-virtio.xml @@ -9,7 +9,6 @@ <boot dev='hd'/> </os> <features> - <acpi/> <apic/> <pae/> </features> diff --git a/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live.xml b/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live.xml index 6eb60b13a9..f0570b5cf4 100644 --- a/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live.xml +++ b/tests/qemuhotplugtestdomains/qemuhotplug-base-ccw-live.xml @@ -9,7 +9,6 @@ <boot dev='hd'/> </os> <features> - <acpi/> <apic/> <pae/> </features>
All of the above are changes in*input* files which are not justified (or mentioned for that matter) in the commit message.
If possible preferrably drop them in a separate commit or at least provide justification why that is not possible.
The last caps replies we added in libvirt for s390x has been 6.0.0. The changes in QEMU and acpi handling in libvirt now list s390x as not supporting acpi. The handling from toleration and ignore acpi switched to no toleration and enforce it. Therefore I added these changes into the capabilities upgrade. Anyway I will move these changes into a preparing standalone patch. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294