Re: [libvirt PATCH v2 2/3] build: Add userfaultfd_sysctl build option
On a Tuesday in 2024, Jiri Denemark wrote:
On Tue, Feb 13, 2024 at 18:48:59 +0100, Jiri Denemark wrote:
> I didn't explicitly test mingw builds, but I tested running meson setup
> with all combinations, especially with -Dsysctl_config=disabled and not
> specifying userfaultfd_sysctl option at all and it worked as expected:
>
> sysctl config : NO
> userfaultfd sysctl : NO
>
> Sure, I can easily fix this by passing -Duserfaultfd_sysctl=disable
> for mingw builds, but I'm wondering why the build doesn't work with just
> -Dsysctl_config=disabled?
Oh I see, the %meson* RPM macros explicitly enable all auto features
using --auto-features=enabled.
That is true for %meson, but it does not seem to be for %mingw_meson
where we add --auto-features=enabled to its invocation.
Jano
Jirka
_______________________________________________
Devel mailing list -- devel(a)lists.libvirt.org
To unsubscribe send an email to devel-leave(a)lists.libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)