Re: [libvirt] [PATCH 09/14] rpc: Merge critical sections and preparations for upcoming patches

On 12/12/2017 06:36 AM, Marc Hartmayer wrote: > Merge critical sections for virNetServerProcessClients and take the > lock of @client before we're calling virNetServerClientNeedAuth. This > is done in preparation for upcoming patches and in addition it is more > efficient not to release a lock which is reacquired immediately > afterwards. > > Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Stefan Zimmermann <stzi(a)linux.vnet.ibm.com&gt; > --- > src/libvirt_remote.syms | 3 ++- > src/rpc/virnetserver.c | 12 ++++++++---- > src/rpc/virnetserverclient.c | 22 ++++++++++++++-------- > src/rpc/virnetserverclient.h | 3 ++- > 4 files changed, 26 insertions(+), 14 deletions(-) > I think if you split out the virNetServerClientIsClosedLocked into its own patch before/after the virNetServerClientNeedAuthLocked, then perhaps patch 7 and 9 are combined.

It's just a patch ordering and trying not to do too much in one patch. > diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms > index 3ce5694b781d..efdf912ec563 100644 > --- a/src/libvirt_remote.syms > +++ b/src/libvirt_remote.syms