Re: [libvirt] [PATCH] Include stdint.h in libvirt.h for INT64_MAX

On Wed, Mar 09, 2011 at 10:49:34AM +0100, Matthias Bolte wrote: > I found this one while trying to compile ruby-libvirt. > > Matthias > From 6858713a7ea7fad961acbc4d4f3c0c53ede2302d Mon Sep 17 00:00:00 2001 > From: Matthias Bolte <matthias.bolte(a)googlemail.com&gt; > Date: Wed, 9 Mar 2011 10:42:49 +0100 > Subject: [PATCH] Include stdint.h in libvirt.h for INT64_MAX > > VIR_DOMAIN_MEMORY_PARAM_UNLIMITED uses INT64_MAX but stdint.h > was not included. Therefore, libvirt.h was not selfcontained. I'm a little wary of doing this, because stdint.h isn't neccessary the most portable header file & while libvirt internally can rely on gnulib to fix problems, apps building against libvirt don't have that. I think it could be better to just define VIR_DOMAIN_MEMORY_PARAM_UNLIMITED directly to the right value, rather than in terms of INT64_MAX