Re: [libvirt] [PATCH 03/10] list: Implement the RPC calls for virConnectListAllStoragePools
On 09/04/2012 05:48 PM, Eric Blake wrote:
On 09/04/2012 09:16 AM, Osier Yang wrote:
> The RPC generator doesn't support returning list of object, this patch do
s/patch do/patch does/
> the work manually.
>
> @@ -5612,6 +5675,7 @@ static virStorageDriver storage_driver = {
> .listPools = remoteListStoragePools, /* 0.4.1 */
> .numOfDefinedPools = remoteNumOfDefinedStoragePools, /* 0.4.1 */
> .listDefinedPools = remoteListDefinedStoragePools, /* 0.4.1 */
> + .listAllPools = remoteConnectListAllStoragePools, /* 0.10.0 */
0.10.2.
ACK with that change.
Correction; one other change is also necessary:
--- remote_protocol-structs 2012-09-04 18:06:02.780444947 -0600
+++ remote_protocol-struct-t3 2012-09-04 18:06:40.975481943 -0600
@@ -2018,7 +2018,7 @@
struct remote_connect_list_all_storage_pools_ret {
struct {
u_int pools_len;
- remote_nonnull_domain * pools_val;
+ remote_nonnull_storage_pool * pools_val;
} pools;
u_int ret;
};
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 617 bytes)